DM-43445: Camera load in Prompt Processing assumes a single unbounded collection #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Mar 25, 2024
| "camera", | ||
| instrument=self.instrument.getName(), | ||
| collections=self.instrument.makeUnboundedCalibrationRunName(), | ||
| ) |
There was a problem hiding this comment.
I think this is a possible alternative:
camera_ref = self.central_butler.find_dataset(
"camera",
instrument=self.instrument.getName(),
collections=self.instrument.makeCalibrationCollectionName(),
timespan=Timespan(begin=None, end=None)
)
self.camera = butler.get(camera_ref)
it's a shame Butler.get doesn't accept timespan and forward that down to its own find_dataset call directly.
Your original looks fine, but if what I've written works, it'll avoid dependence on one of our shakier convention.
There was a problem hiding this comment.
I will look at forwarding timespan in DM-43499.
There was a problem hiding this comment.
I'd like to give it a shot, but the "live" tests have turned up serious problems that will keep me busy up until the code freeze. I'll add a TODO comment and try your suggestion as part of DM-42825 (hopefully in April!).
There was a problem hiding this comment.
This support was added in lsst/daf_butler#982
The new code can get the camera from calib (preferred), or fall back to calib/unbounded as before.
kfindeisen
force-pushed
the
tickets/DM-43445
branch
from
9dd6368 to
b0654d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the code for loading the initial
cameradataset to get it from<instrument>/calibwhere possible, keeping the old behavior of<instrument>/calib/unboundedonly as a fallback for older repos.