DM-43750: Fix crash when using NameKeyCollectionManager #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhirving
force-pushed
the
tickets/DM-43750
branch
from
3d98541
to
41d24d3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
=======================================
Coverage 88.94% 88.95%
=======================================
Files 341 341
Lines 44036 44042 +6
Branches 9072 9069 -3
=======================================
+ Hits 39169 39177 +8
+ Misses 3552 3550 -2
Partials 1315 1315 ☔ View full report in Codecov by Sentry. |
Fix an issue where NameKeyCollectionManager would throw an exception when assigning a collection chain for a collection whose record was already in the collection cache. This was happening because of an optimization that caused the "by key" cache to not be populated when using NameKeyCollectionManager, but some code paths assumed that both the "by name" and "by key" caches are always available. Fixed the bug by removing the optimization, ensuring the behavior is the same for all implementations.
Running these tests against both CollectionManager implementations would have caught the bug in the previous commit.
dhirving
force-pushed
the
tickets/DM-43750
branch
from
41d24d3
to
8f6f177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where NameKeyCollectionManager would throw an exception when assigning a collection chain for a collection whose record was already in the collection cache.
This was happening because of an optimization that caused the "by key" cache to not be populated when using NameKeyCollectionManager, but some code paths assumed that both the "by name" and "by key" caches are always available. Fixed the bug by removing the optimization, ensuring the behavior is the same for all implementations.
Checklist
doc/changesconfigs/old_dimensions