Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43750: Fix crash when using NameKeyCollectionManager #993

Merged
merged 2 commits into from
Apr 9, 2024
Merged

DM-43750: Fix crash when using NameKeyCollectionManager #993

merged 2 commits into from
Apr 9, 2024

Commits on Apr 9, 2024

  1. Fix crash when using NameKeyCollectionManager 

    Fix an issue where NameKeyCollectionManager would throw an exception when assigning a collection chain for a collection whose record was already in the collection cache.

This was happening because of an optimization that caused the "by key" cache to not be populated when using NameKeyCollectionManager, but some code paths assumed that both the "by name" and "by key" caches are always available.  Fixed the bug by removing the optimization, ensuring the behavior is the same for all implementations.
    @dhirving
    dhirving committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    aeb5b64 View commit details
    Browse the repository at this point in the history

  2. Run test_simpleButler w/ NameKeyCollectionmanager 

    Running these tests against both CollectionManager implementations would have caught the bug in the previous commit.
    @dhirving
    dhirving committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    8f6f177 View commit details
    Browse the repository at this point in the history