DM-41028: Add schema version support and check to SQL backend #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebellm
approved these changes
Jan 23, 2024
| return VersionTuple.fromString(version_str) | ||
| return default | ||
|
|
||
| initial_version = VersionTuple(0, 1, 0) |
There was a problem hiding this comment.
I was confused why this wasn't VERSION, so a comment pointing out that this is used to specify versions in old schemas when the metadata is not present would be helpful.
There was a problem hiding this comment.
👍 I'll add a comment.
Apdb class now has an associated version number and schema version number (latter comes from YAML schema). Both version numbers are stored in metadata table when schema is initialized. Versions are read when ApdbSql is instantiated and version numbers are compared to what is defined in YAML and in the code.
Also improved handling of empty schema in SQL backend.
andy-slac
force-pushed
the
tickets/DM-41028
branch
from
86ccfeb
to
54a2978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apdb now understands
metadatatable specification in sdm_schemas. Apdb now verifies that its own version and schema version in sdm_schemas are compatible with the versions stored in metadata table. Both metadata table and sdm_schemas version numbers are optional, if they are missing they are assumed to be "0.1.0".