DM-35060: Use piff for characterizeImage in DRP #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
What's going on with yamllint here is that its default (which we use) for the indent-sequences rule is "consistent", which means it doesn't care whether you indent sequences relative to their parent or not, as long as you do it consistently within a file. And your additions (which are, I suspect, now the first sequences in the file) do not indent, while all later ones do.
parejkoj
force-pushed
the
tickets/DM-35060
branch
2 times, most recently
from
3bf372e
to
e3b47e8
Compare
See DM-35207: we need to verify that it's ok to have psfex for the initial psf determination and piff for the final.
parejkoj
force-pushed
the
tickets/DM-35060
branch
from
0bae844
to
a7ffcb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.