DM-42663: Change default sourceSelector to new moments based selector in gbdes #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
changed the title
parejkoj
reviewed
Feb 21, 2024
| @@ -340,6 +340,7 @@ def _make_sourceCat(cls, starIds, starRas, starDecs, trueWCSs, inScienceFraction | |||
| "hsmPsfMoments_flag", | |||
| "apFlux_12_0_flag", | |||
| "extendedness", | |||
| "sizeExtendedness", | |||
There was a problem hiding this comment.
Any reason you have both of these here?
There was a problem hiding this comment.
We still want to propagate the what I call "flux extendedness" values, but switch from using one to another. At some future point, I'd like to make slot_extendedness that can point to either, but not in the near future.
TallJimbo
approved these changes
Feb 22, 2024
arunkannawadi
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.