Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42663: Change default sourceSelector to new moments based selector in gbdes #44

Merged
merged 1 commit into from
Feb 29, 2024
Merged

DM-42663: Change default sourceSelector to new moments based selector in gbdes #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/lsst/drp/tasks/gbdesAstrometricFit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def setDefaults(self):
# Use only stars because aperture fluxes of galaxies are biased and
# depend on seeing.
self.sourceSelector["science"].doUnresolved = True
self.sourceSelector["science"].unresolved.name = "extendedness"
self.sourceSelector["science"].unresolved.name = "sizeExtendedness"

# Use only isolated sources.
self.sourceSelector["science"].doIsolated = True
Expand Down
1 change: 1 addition & 0 deletions tests/test_gbdesAstrometricFit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ def _make_sourceCat(cls, starIds, starRas, starDecs, trueWCSs, inScienceFraction
"hsmPsfMoments_flag",
"apFlux_12_0_flag",
"extendedness",
"sizeExtendedness",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you have both of these here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want to propagate the what I call "flux extendedness" values, but switch from using one to another. At some future point, I'd like to make slot_extendedness that can point to either, but not in the near future.

"parentSourceId",
"deblend_nChild",
"ixy",
Expand Down