Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-21916: SQuaSH upload of Gen 3 Measurements #66

Merged
merged 4 commits into from
Feb 23, 2021
Merged

DM-21916: SQuaSH upload of Gen 3 Measurements #66

merged 4 commits into from
Feb 23, 2021

Conversation

kfindeisen
Copy link
Member

@kfindeisen kfindeisen commented Feb 20, 2021

This PR moves the make_job_document.py script, and the jobReporter module that backs it, to lsst.verify. Since the lsst.verify edition makes some changes to the command-line interface to support a broader range of users (lsst/verify#77), a new make_job_document.py has been created that keeps the old interface for backwards-compatibility but is implemented using lsst.verify.

Copy link
Contributor

@SimonKrughoff SimonKrughoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for making modifying the job reporting script and for preserving the interface

The jobReporter script has been moved to the 'tickets/DM-21916-transfer'
branch of lsst/verify.
This script now delegates to lsst.verify, but preserves the
validate_drp-specific interface of the original.
@kfindeisen
Copy link
Member Author

Ok, I think I've rebased everything correctly. @SimonKrughoff, can you do the merge, since I don't have write permissions?

@SimonKrughoff SimonKrughoff merged commit 75edc93 into lsst:master Feb 23, 2021
@SimonKrughoff
Copy link
Contributor

Done. It didn't make it for the nightly, but I don't think that's a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants