DM-21916: SQuaSH upload of Gen 3 Measurements #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jobReporter script has been moved from the 'tickets/DM-21916-transfer' branch of lsst-dmsst/metric-pipeline-tasks (soon to be lsst/faro).
The metric-pipeline-tasks/faro repository used a 110-character limit; verify uses 80.
This change allows for less code duplication between make_job_document.py and a compatibility version in metric-pipeline-tasks/faro.
This change prevents any name collissions with the compatibility script in metric-pipeline-tasks, and is less ambiguous in the context of other lsst.verify scripts.
This allows package documentation builds with Documenteer 0.6.
This change requires moving the script's parser into python.
JobReporter continues to always provide a physical filter, but now only deduces one if it's not in the data ID.
The previous defaults were customized for validate_drp processing. The alternative CLI in metric-pipeline-tasks/faro keeps the defaults, for those who want them.
SimonKrughoff
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
make_job_document.pyscript, and thejobReportermodule that backs it, frommetric-pipeline-tasks, and generalizes it to work on a broader range of instrumented Gen 3 repositories. This includes three UI changes:gen3_to_job.py, both because the old name is ambiguous in a package where most scripts make jobs, and to avoid confusion with the backwards-compatible version added on DM-21916: SQuaSH upload of Gen 3 Measurements faro#66.--metrics_packageargument now defaults to allowing all metrics, regardless of namespace.--dataset_nameargument now has no default, and is mandatory.This PR also adds support for Faro's
butler_generationtag to the existing Gen 2MetricTasksupport code.