DM-38304: Fix crash in load-tap --dry-run command
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
force-pushed
the
tickets/DM-38304
branch
from
10541af
to
823f87e
Compare
andy-slac
changed the title
load-tap --dry-run commandload-tap --dry-run command
`create_mock_engine` does not actually return an Engine, but a MockConnection instance which has very different API. Updated TapLoadingVisitor to handle their differences correctly. Added unit test for `load-tap --dry-run`.
andy-slac
force-pushed
the
tickets/DM-38304
branch
from
823f87e
to
751c910
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
+ Coverage 97.93% 97.96% +0.02%
==========================================
Files 6 6
Lines 388 393 +5
==========================================
+ Hits 380 385 +5
Misses 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Can you turn on python 3.11 in the build matrix? |
timj
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_mock_enginedoes not actually return an Engine, but a MockConnection instance which has very different API. Updated TapLoadingVisitor to handle their differences correctly. Added unit test forload-tap --dry-run.