Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38304: Fix crash in load-tap --dry-run command #19

Merged
merged 2 commits into from
Mar 9, 2023

Commits on Mar 9, 2023

  1. Fix crash in load-tap --dry-run command (DM-38304)

    `create_mock_engine` does not actually return an Engine, but a MockConnection
    instance which has very different API. Updated TapLoadingVisitor to handle
    their differences correctly. Added unit test for `load-tap --dry-run`.
    andy-slac committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    751c910 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d428e0f View commit details
    Browse the repository at this point in the history