DM-42544: Add check for duplicate IDs when validating a schema #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 92.71% 92.58% -0.14%
==========================================
Files 18 18
Lines 1923 1943 +20
Branches 381 381
==========================================
+ Hits 1783 1799 +16
- Misses 86 87 +1
- Partials 54 57 +3 ☔ View full report in Codecov by Sentry. |
JeremyMcCormick
force-pushed
the
tickets/DM-42544
branch
from
8e2afc6
to
3085445
Compare
The function for creating the ID map was not working and was rewritten to use a visitor pattern instead of recursion. Duplicates are added to a set as the schema is visited. The model_validator will raise an error if duplicates are found and print a complete list of the duplicated IDs.
This was not checked before but validating a schema will always check for duplicates now. A few duplicate IDs are fixed now that were used unintentionally.
An error will be thrown if the object is not found.
JeremyMcCormick
force-pushed
the
tickets/DM-42544
branch
from
3085445
to
b1d7790
Compare
gpdf
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function for building a map of IDs to objects was rewritten using a visitor pattern, as the old version using recursion was prone to error and not working consistently. Duplicates are added to a set as the schema is visited. The
model_validatorfunction will throw an error if any duplicates are found, which will include a complete list of all the duplicate IDs. The new implementation of the ID builder and duplicate check was tested by running on several sdm_schemas which are known to contain duplicate IDs (imsim, hsc). These will be fixed in a different ticket branch on sdm_schemas.