Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42544: Add check for duplicate IDs when validating a schema #34

Merged
merged 4 commits into from
Jan 23, 2024
Merged

DM-42544: Add check for duplicate IDs when validating a schema #34

merged 4 commits into from
Jan 23, 2024

Commits on Jan 23, 2024

  1. Add check for duplicate IDs when validating a schema 

    The function for creating the ID map was not working and was rewritten
to use a visitor pattern instead of recursion. Duplicates are added to
a set as the schema is visited. The model_validator will raise an error
if duplicates are found and print a complete list of the duplicated
IDs.
    @JeremyMcCormick
    JeremyMcCormick committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    2f1db60 View commit details
    Browse the repository at this point in the history

  2. Remove duplicate object IDs in test 

    This was not checked before but validating a schema will always check
for duplicates now. A few duplicate IDs are fixed now that were used
unintentionally.
    @JeremyMcCormick
    JeremyMcCormick committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    3512ca8 View commit details
    Browse the repository at this point in the history

  3. Add a method to get an object within a schema by its ID 

    An error will be thrown if the object is not found.
    @JeremyMcCormick
    JeremyMcCormick committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    4f8a657 View commit details
    Browse the repository at this point in the history

  4. Add a test to verify that duplicate IDs in a schema will raise an error

    @JeremyMcCormick
    JeremyMcCormick committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    b1d7790 View commit details
    Browse the repository at this point in the history