DM-41247: Add tool that checks for redundant datatype definitions #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pydantic itself uses a global settings dictionary for data models, so follow this style for validation options.
This was needed in SQLAlchemy v1 but should not be needed in v2.
If there are 'mysql:datatype' annotations present in the column data, check that they are not redundant. The datatypes are checked to see if they compile to the same SQL string in the target dialect.
Since the method to populate the ID map may be called multiple times if the schema is updated after being built, it is safer to construct the ID map in the post init hook rather than activate it using a validator.
JeremyMcCormick
force-pushed
the
tickets/DM-41247
branch
from
d95b004
to
941933f
Compare
gpdf
approved these changes
Apr 12, 2024
timj
added a commit
that referenced
this pull request
Apr 12, 2024
DM-41247: Revert "Merge pull request #50 from lsst/tickets/DM-41247"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Pydantic validator that will identity variant type overrides, e.g.,
mysql:datatypevalues, that appear to be redundant. To determine whether the datatypes are the same, they are each compiled to a SQL snippet. If the resultant SQL is identical, then the type override is considered to be superfluous and an error is raised.The validation needs to be turned on using the
-t/--check-redundant-datatypesflag when running thevalidatecommand.