Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41247: Add tool that checks for redundant datatype definitions #50

Merged
merged 19 commits into from
Apr 12, 2024

Commits on Apr 4, 2024

  1. Use global class variable for setting validation flags

    Pydantic itself uses a global settings dictionary for data models, so
    follow this style for validation options.
    JeremyMcCormick committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    674b2f7 View commit details
    Browse the repository at this point in the history
  2. Remove the unnecessary implementation of custom double type

    This was needed in SQLAlchemy v1 but should not be needed in v2.
    JeremyMcCormick committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    6a89b84 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2ef40f0 View commit details
    Browse the repository at this point in the history
  4. Implement redundant type checking for MySQL datatype annotations

    If there are 'mysql:datatype' annotations present in the column data,
    check that they are not redundant.
    
    The datatypes are checked to see if they compile to the same SQL
    string in the target dialect.
    JeremyMcCormick committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    98588ce View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Configuration menu
    Copy the full SHA
    892116e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7e30331 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    7a3e74e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cdcd842 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f43d5f6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    50a820f View commit details
    Browse the repository at this point in the history
  5. Populate the ID map for the schema in the post init hook

    Since the method to populate the ID map may be called multiple times if
    the schema is updated after being built, it is safer to construct the
    ID map in the post init hook rather than activate it using a validator.
    JeremyMcCormick committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8a946ea View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4f20fac View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cce9ebe View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b63285e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    56f0bf6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7a42128 View commit details
    Browse the repository at this point in the history
  11. Fix mypy errors

    JeremyMcCormick committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    fb3be4f View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e9623eb View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    941933f View commit details
    Browse the repository at this point in the history