Skip to content

Commit

Permalink
Merge pull request #83 from lsst/tickets/DM-34798
Browse files Browse the repository at this point in the history
DM-34768: Loosen fgcmcal chebyshev test tolerance
  • Loading branch information
erykoff committed May 13, 2022
2 parents 0047a03 + 3c85571 commit 25d357f
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/test_chebyshev.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def test_chebyshev_evaluate(self, seed=1000):
field = afwMath.ChebyshevBoundedField(bbox, self.pars)
fieldValues = field.evaluate(xPos, yPos)

self.assertFloatsAlmostEqual(fieldValues, fgcmValues, rtol=5e-15)
self.assertFloatsAlmostEqual(fieldValues, fgcmValues, rtol=1e-14)

def test_chebyshev_fit(self, seed=1000):
"""
Expand Down Expand Up @@ -138,16 +138,16 @@ def test_chebyshev_fit(self, seed=1000):
# The tolerance here must be looser than the application, I believe
# because of rounding errors in the fit implementations. But the
# good news is that a tolerance of 1e-9 in parameters in these
# tests yields a recovered tolerance of < 5e-15.
# tests yields a recovered tolerance of < 1e-14.
self.assertFloatsAlmostEqual(fgcmField.pars, field.getCoefficients(),
rtol=1e-9)

# And compare the input and output
fgcmValues2 = fgcmField.evaluate(xPos, yPos)
fieldValues2 = field.evaluate(xPos, yPos)

self.assertFloatsAlmostEqual(fgcmValues, fgcmValues2, rtol=5e-15)
self.assertFloatsAlmostEqual(fgcmValues2, fieldValues2, rtol=5e-15)
self.assertFloatsAlmostEqual(fgcmValues, fgcmValues2, rtol=1e-14)
self.assertFloatsAlmostEqual(fgcmValues2, fieldValues2, rtol=1e-14)


class TestMemory(lsst.utils.tests.MemoryTestCase):
Expand Down

0 comments on commit 25d357f

Please sign in to comment.