DM-34768: Loosen fgcmcal chebyshev test tolerance #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
May 13, 2022
| @@ -97,7 +97,7 @@ def test_chebyshev_evaluate(self, seed=1000): | |||
| field = afwMath.ChebyshevBoundedField(bbox, self.pars) | |||
| fieldValues = field.evaluate(xPos, yPos) | |||
|
|
|||
| self.assertFloatsAlmostEqual(fieldValues, fgcmValues, rtol=5e-15) | |||
| self.assertFloatsAlmostEqual(fieldValues, fgcmValues, rtol=1e-14) | |||
There was a problem hiding this comment.
Is three uses enough for this to be a file constant?
There was a problem hiding this comment.
They only need to be the same if we think a change in one tolerance should be reflected in the others. The number of uses is irrelevant in and of itself if the reused constant merely happens to be the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.