DM-40500: remove now-unnecessary lookupFunctions. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-40500
branch
from
7b8f9e5
to
aa49581
Compare
Following DM-38498 static calibrations *with multiple=False* connections are now found correctly without any customization by the task.
TallJimbo
force-pushed
the
tickets/DM-40500
branch
2 times, most recently
from
9ff8052
to
00369d4
Compare
This is probably a bit slower than the previous version, because it can use multiple smaller queries instead of a single larger one (depending on dimensions). But it's at most n_detectors or n_physical_filters extra queries, and that's a small price to pay for being able to get rid of the special "unbounded" collection.
TallJimbo
force-pushed
the
tickets/DM-40500
branch
from
00369d4
to
865d8bc
Compare
czwa
approved these changes
Aug 28, 2023
| # For static calibrations, we search with a timespan that has unbounded | ||
| # begin and end; we'll get an error if there's more than one match (because | ||
| # then it's not static). | ||
| timespan = Timespan(begin=None, end=None) |
There was a problem hiding this comment.
This will not be true with a "versioned camera," but as that's been a moving target for multiple years now, I'm happy to defer that issue until it becomes relevant.
There was a problem hiding this comment.
Yes, and I no longer think giving actual camera datasets different validity ranges is ever going to be a part of the versioned camera system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.