DM-23331: Add support for default config files in obs_subaru #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that obs_subaru has default fgcmcal configs, the way the tests had been setting test configs no longer worked. Now the default configs are read in from files, which can override the ones in obs_subaru appropriate for the test data.
This addition guarantees that the reference catalog will not have index mismatches with certain configurations. This also allows more flexibility when running with different fit configurations.
TallJimbo
approved these changes
Feb 7, 2020
| @@ -179,9 +179,6 @@ def getTargetList(parsedCmd): | |||
| """ | |||
| return [parsedCmd.butler] | |||
|
|
|||
| def precall(self, parsedCmd): | |||
| return True | |||
|
|
|||
There was a problem hiding this comment.
Note that this will also lead to config-checking. Will that cause a --clobber-config to be necessary when doing multiple iterations with different configs, or is that no longer how things work?
There was a problem hiding this comment.
So this is for the output products, which should only be run once, so that's not a problem. (Well, you can run it more than once, but then you would need to clobber which is intended). The fit cycle has its own config checking code to deal with that issue, and that's still in place.
python/lsst/fgcmcal/utilities.py
Outdated
|
|
||
| Returns | ||
| ------- | ||
| refMag : `np.array` |
There was a problem hiding this comment.
The actual type is np.ndarray; np.array is just a function that makes one.
FGCM now can support listing bands in the config that are unused in a given run. Tests have been added to ensure that this works as expected, and fixes have been put in accordingly.
erykoff
force-pushed
the
tickets/DM-23331
branch
from
d8d9351
to
ae80f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests accordingly, and also update FGCM code to elegantly handle missing bands.