Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-23331: Add support for default config files in obs_subaru #27

Merged
merged 6 commits into from
Feb 7, 2020
Merged

DM-23331: Add support for default config files in obs_subaru #27

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
44a0d0c
Refactor test configs to be compatible with obs_subaru default configs.
erykoff Feb 5, 2020
4ab6cb7
Remove restriction that LUTs cannot be rebuilt.
erykoff Feb 6, 2020
5ae6d92
Add filtername metadata to fgcm reference stars.
erykoff Feb 6, 2020
25b372f
Remove extraneous precall which prevents config persistence.
erykoff Feb 6, 2020
e68972d
Fix crash when using doSubtractLocalBackground in tract mode.
erykoff Feb 6, 2020
ae80f89
Update tests for when the config has an unused band.
erykoff Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions python/lsst/fgcmcal/fgcmOutputProducts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,6 @@ def getTargetList(parsedCmd):
"""
return [parsedCmd.butler]

def precall(self, parsedCmd):
return True

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this will also lead to config-checking. Will that cause a --clobber-config to be necessary when doing multiple iterations with different configs, or is that no longer how things work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is for the output products, which should only be run once, so that's not a problem. (Well, you can run it more than once, but then you would need to clobber which is intended). The fit cycle has its own config checking code to deal with that issue, and that's still in place.

def __call__(self, butler):
"""
Parameters
Expand Down