Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-35836: Deprecate old cycleNumber in favor of correct connection setting. #88

Merged
merged 1 commit into from Aug 4, 2022
Merged

DM-35836: Deprecate old cycleNumber in favor of correct connection setting. #88

merged 1 commit into from Aug 4, 2022

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Aug 4, 2022

No description provided.

parejkoj
parejkoj approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run jenkins with ci_hsc for this? I think that's the minimum test dataset to check this kind of change, except I don't remember if ci_hsc runs fgcmcal (I suspect it doesn't). Do you have to run rc2_subset or something?

python/lsst/fgcmcal/fgcmOutputProducts.py Show resolved Hide resolved
@erykoff
Copy link
Contributor Author

erykoff commented Aug 4, 2022

This would only show up with rc2_subset, not ci_hsc. I'm confident in the fix and the local test coverage that it will work, and am willing to take the risk tonight.

@erykoff erykoff merged commit d96da90 into main Aug 4, 2022
@erykoff erykoff deleted the tickets/DM-35836 branch August 4, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parejkoj parejkoj parejkoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erykoff @parejkoj