DM-39227: rename (with deprecation) SubtractImages external-calibration connections. #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallJimbo
force-pushed
the
tickets/DM-39227
branch
from
76403e9
to
dc481ef
Compare
isullivan
approved these changes
Jul 11, 2023
| @@ -69,12 +72,26 @@ class SubtractInputConnections(lsst.pipe.base.PipelineTaskConnections, | |||
| dimensions=("instrument", "visit"), | |||
| storageClass="ExposureCatalog", | |||
| name="finalVisitSummary", | |||
| # TODO: remove on DM-39854. | |||
| deprecated=( | |||
| "Deprecated in favor of visitSummary. Will be removed after v26." | |||
There was a problem hiding this comment.
When I wrote this, yes, it should have been v27. Now that RFC-945 is adopted I'm going to anticipate its implementation by just a bit and leave it as v26.
| "Deprecated in favor of visitSummary. Will be removed after v26." | ||
| ) | ||
| ) | ||
| visitSummary = connectionTypes.Input( |
There was a problem hiding this comment.
For consistency, please either name this calibrationsCatalog in the connections, or use visitSummary later instead of calibrationsCatalog
A few of these were above our docstring column limit, but most just had line breaks in arbitrary places. Automatic docstring-wrapping tools are great!
The new names reflect the possibility of getting PhotoCalibs and WCSs from the same catalogs, though we're not doing that yet. In addition, whether external calibrations are applied when 'run' methods are called directly is now contingent on whether external calibrations were passed in, not a config option; the config option just controls whether those connections are active (and hence how 'run' is called) when being run as a PipelineTask.
TallJimbo
force-pushed
the
tickets/DM-39227
branch
from
b1373c9
to
f81eab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.