Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39227: rename (with deprecation) SubtractImages external-calibration connections. #270

Merged
merged 3 commits into from
Jul 13, 2023
Merged

DM-39227: rename (with deprecation) SubtractImages external-calibration connections. #270

merged 3 commits into from
Jul 13, 2023

Commits on Jul 13, 2023

  1. Rewrap docstrings in subtractImages. 

    A few of these were above our docstring column limit, but most just
had line breaks in arbitrary places.  Automatic docstring-wrapping
tools are great!
    @TallJimbo
    TallJimbo committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f96c386 View commit details
    Browse the repository at this point in the history

  2. Rename (with deprecation) symbols for subtractImages calibration. 

    The new names reflect the possibility of getting PhotoCalibs and WCSs
from the same catalogs, though we're not doing that yet.

In addition, whether external calibrations are applied when 'run'
methods are called directly is now contingent on whether external
calibrations were passed in, not a config option; the config option
just controls whether those connections are active (and hence how
'run' is called) when being run as a PipelineTask.
    @TallJimbo
    TallJimbo committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    e65cea9 View commit details
    Browse the repository at this point in the history

  3. Rename calibrationsCatalog->visitSummary for consistency.

    @TallJimbo
    TallJimbo committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f81eab2 View commit details
    Browse the repository at this point in the history