DM-41943: Do-over 41118 (opening for review) #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yalsayyad
commented
Dec 6, 2023
| detNegPix = (mask.array & mask.getPlaneBitMask("DETECTED_NEGATIVE")) > 0 | ||
| self.metadata.add("nPixelsDetectedPositive", np.sum(detPosPix)) | ||
| self.metadata.add("nPixelsDetectedNegative", np.sum(detNegPix)) | ||
| detPosPix *= ~goodPix |
There was a problem hiding this comment.
Took me a sec to realize you meant detPosPix &= ~goodPix.
What you have works, but was slower for this reader to read.
| if template_coverage < config.requiredTemplateFraction: | ||
| doRaise = True | ||
| elif template_coverage < config.minTemplateFractionForExpectedSuccess: | ||
| doRaise = True |
There was a problem hiding this comment.
The task only raises NoWorkFound if you get a RuntimeError or lsst.pex.exceptions.Exception. I didn't follow how/that you designed the input image to subtract successfully for 0.7 but not for 0.19. Maybe an inline comment to help me out.
Also, if you designed these input images so that the 0.19 fails, then that also means that if I change the default for minTemplateFractionForExpectedSuccess to 0.18, this test would fail.
…emplate coverage.
isullivan
force-pushed
the
tickets/DM-41943
branch
from
f73a65e
to
1049ab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.