Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-41108: Add missing template coverage fraction metric #302

Merged
merged 1 commit into from Mar 15, 2024

Conversation

isullivan
Copy link
Contributor

@isullivan isullivan commented Mar 8, 2024

A bugfix on DM-41943 removed the calculation of templateCoverageFraction but did not update analysis_tools. This adds the metric calculation back in.

@kfindeisen
Copy link
Member

Are you referring to #288? I don't see the templateCoveragePercent removal anywhere there....

@isullivan
Copy link
Contributor Author

Sorry, it was removed on #286 without a ticket, since main was broken, and DM-41943 re-implemented the reverted code without this metric. I unfortunately did not also remove the metric from analysis_tools, which left it broken.

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, now things make sense. I agree that this implementation is much better.

@isullivan isullivan merged commit 9c4eec7 into main Mar 15, 2024
2 checks passed
@isullivan isullivan deleted the tickets/DM-41108 branch March 15, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants