Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-13609: Undo EXTRACT_PRIVATE override in ip_diffim #80

Merged
merged 1 commit into from Mar 13, 2018

Conversation

kfindeisen
Copy link
Member

This PR implements RFC-451 by making ip_diffim use the default documentation level (public+protected). The change has been tested locally with both package- and stack-level documentation builds.

The override was having some unexpected side effects for Stack-wide
documentation, and does not appear to be used by anybody currently
developing ip_diffim.
Copy link
Member

@jonathansick jonathansick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for it.

@kfindeisen kfindeisen merged commit 110db55 into master Mar 13, 2018
@ktlim ktlim deleted the tickets/DM-13609 branch August 25, 2018 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants