DM-20112: ip_isr is not handling BAD pixels as expected #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With interpolation on, these pixels are interpolated, which means they do not receive the image median value. This may skew the interpolation. Fix interpolation exposure choice bug.
Amplifiers that are entirely SAT or SUSPECT do not have the overscan measured and subtracted. However, we were not setting the BAD mask bit, which meant these amplifiers were not rejected from consideration later, allowing them to be used as an endpoint of interpolation. This was obviously wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move BAD pixel value setting before interpolation.
With interpolation on, these pixels are interpolated, which means they
do not receive the image median value. This may skew the
interpolation.
Fix interpolation exposure choice bug.