Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-20112: ip_isr is not handling BAD pixels as expected #100

Merged
merged 4 commits into from
Jun 27, 2019
Merged

DM-20112: ip_isr is not handling BAD pixels as expected #100

merged 4 commits into from
Jun 27, 2019

Commits on Jun 20, 2019

  1. Move BAD pixel value setting before interpolation. 

    With interpolation on, these pixels are interpolated, which means they
do not receive the image median value.  This may skew the
interpolation.

Fix interpolation exposure choice bug.
    @czwa
    czwa committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    649a561 View commit details
    Browse the repository at this point in the history

  2. Set BAD mask bit if an amplifier is declared bad. 

    Amplifiers that are entirely SAT or SUSPECT do not have the overscan
measured and subtracted.  However, we were not setting the BAD mask
bit, which meant these amplifiers were not rejected from consideration
later, allowing them to be used as an endpoint of interpolation.  This
was obviously wrong.
    @czwa
    czwa committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    0f89428 View commit details
    Browse the repository at this point in the history

  3. Update debugView method to wait to continue.

    @czwa
    czwa committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    1952e65 View commit details
    Browse the repository at this point in the history

  4. Clarify interpolation comments.

    @czwa
    czwa committed Jun 20, 2019
    Configuration menu
    Copy the full SHA
    4c19aa0 View commit details
    Browse the repository at this point in the history