DM-30015: Update Sphinx conf.py for documenteer 0.6 #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-30015
branch
from
46a81d2
to
4c97c54
Compare
timj
force-pushed
the
tickets/DM-30015
branch
from
4c97c54
to
b15ad26
Compare
|
@czwa since this pull request wanted to tidy up the flake8 exceptions I decided I should fix the W505 problems rather than keep putting them off. I don't like exceptions for things which are very easy to fix. Please take a look. I didn't try to fix the vestigial doxygen docstrings. There was one fix that was real and I don't understand why it didn't trigger a problem before. |
timj
reviewed
Dec 7, 2021
python/lsst/ip/isr/calibType.py
Outdated
| @@ -339,7 +340,7 @@ def determineCalibClass(cls, metadata, message): | |||
| calibClassName = metadata.get("CALIBCLS") | |||
| calibClass = doImport(calibClassName) if calibClassName is not None else cls | |||
| if calibClass is IsrCalib: | |||
| raise ValueError(f"Cannot use base class to read calibration data: {msg}") | |||
| raise ValueError(f"Cannot use base class to read calibration data: {message}") | |||
There was a problem hiding this comment.
I'm confused by this one -- surely it should have been complaining before now.
|
Okay. I see that I should have done this on DM-31592. I'll make a new PR for that. |
|
See #205 |
These match the current stack package template: https://github.com/lsst/templates/blob/master/project_templates/stack_package/example/setup.cfg
timj
force-pushed
the
tickets/DM-30015
branch
from
b15ad26
to
31d2754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates based on the latest updates in the package template (https://github.com/lsst/templates/tree/master/project_templates/stack_package)