Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40293: Refactor generalized amp-to-amp offset correction task #289

Merged
merged 1 commit into from Feb 17, 2024
Merged

DM-40293: Refactor generalized amp-to-amp offset correction task #289

merged 1 commit into from Feb 17, 2024

Conversation

enourbakhsh
Copy link
Contributor

No description provided.

@enourbakhsh enourbakhsh force-pushed the tickets/DM-40293 branch 3 times, most recently from 999b4ab to 84b0f06 Compare December 5, 2023 19:43
leeskelvin
leeskelvin reviewed Dec 22, 2023
View reviewed changes
tests/test_ampOffset.py Outdated Show resolved Hide resolved
leeskelvin
leeskelvin reviewed Dec 22, 2023
View reviewed changes
tests/test_ampOffset.py Outdated Show resolved Hide resolved
leeskelvin
leeskelvin reviewed Dec 22, 2023
View reviewed changes
tests/test_ampOffset.py Outdated Show resolved Hide resolved
@leeskelvin
Copy link
Contributor

General comment - you should look into squashing down some of your commits into one or two commits, to capture singular changes.

@enourbakhsh enourbakhsh force-pushed the tickets/DM-40293 branch 2 times, most recently from a86f808 to 12c746f Compare January 3, 2024 06:17
@enourbakhsh enourbakhsh force-pushed the tickets/DM-40293 branch 2 times, most recently from 47fe3b4 to 725901b Compare January 3, 2024 21:16
@enourbakhsh enourbakhsh force-pushed the tickets/DM-40293 branch 6 times, most recently from 1f082f1 to cd1f65f Compare February 17, 2024 05:45
@enourbakhsh enourbakhsh merged commit 87e1003 into main Feb 17, 2024
2 checks passed
@enourbakhsh enourbakhsh deleted the tickets/DM-40293 branch February 17, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeskelvin leeskelvin leeskelvin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@enourbakhsh @leeskelvin