tickets/DM-1448: Move code for mock images so it reusable. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisherlevine
requested changes
Mar 7, 2019
czwa
force-pushed
the
tickets/DM-1448
branch
3 times, most recently
from
31d8744
to
f6111b3
Compare
The examples in this directory have been superseded. The isr.py and runAssembleTask.py scripts produce results that can be obtained from the runIsr.py command line task. Some of the exampleUtils.py code to generate fake image data will be included in the new isrMock.py code.
The added IsrMock code is based on the afw/cameraGeom/testUtils.py and afw/cameraGeom/utils.py code to provide a complete camera geometry/detector/amplifier set, and replaces some example code from ip_isr/examples. The new mocks can be constructed to either represent a "raw" exposure with the inclusion of various instrument signals (bias, dark, flat, etc.), as well as the master calibration frame to allow the removal of those instrument signals. A Gen-2 butler dataRef can also be constructed, to test that IsrTask properly retrieves the appropriate mock data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples in the ip_isr/examples directory have been superseded. The isr.py and runAssembleTask.py scripts produce results that can be obtained from the runIsr.py command line task. Some of the exampleUtils.py code to generate fake image data will be included in the new isrMock.py code.
The added IsrMock code is based on the afw/cameraGeom/testUtils.py and afw/cameraGeom/utils.py code to provide a complete camera geometry/detector/amplifier set, and replaces the example code from ip_isr/examples. The new mocks can be constructed to either represent a "raw" exposure with the inclusion of various instrument signals (bias, dark, flat, etc.), as well as the master calibration frame to allow the removal of those instrument signals. A Gen-2 butler dataRef can also be constructed, to test that IsrTask properly retrieves the appropriate mock data.