DM-13671 add option to skip rank update #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
force-pushed
the
tickets/DM-13671
branch
3 times, most recently
from
2223299
to
4e396a9
Compare
parejkoj
force-pushed
the
tickets/DM-13671
branch
2 times, most recently
from
8dc4db2
to
af25548
Compare
parejkoj
force-pushed
the
tickets/DM-13671
branch
from
b21e418
to
9a4dad6
Compare
TallJimbo
approved these changes
May 19, 2018
python/lsst/jointcal/jointcal.py
Outdated
| """Run fit.minimize up to max_steps times, returning the final chi2.""" | ||
|
|
||
| for i in range(max_steps): | ||
| r = fit.minimize(whatToFit, 5) # outlier removal at 5 sigma. | ||
| # outlier removal at 5 sigma. | ||
| r = fit.minimize(whatToFit, 5, doRankUpdate=doRankUpdate) |
There was a problem hiding this comment.
This is pre-existing, but the sigma threshold for outlier rejection should be configurable.
There was a problem hiding this comment.
Good point. I've been meaning to do that for a while. I've added config.outlierRejectSigma in a separate commit.
Add jointcalConfig option to skip photometry and astrometry rank update. Add FitterBase support for skipping rank update. Add decam photometry and astrometry tests with and without rank update. Decam photometry doRankUpdate test doesn't work, and is part of the set of "differs on macOS" tests, so we're skipping it for now. Lift out Hessian creation into anonymous function. NOTE: astrometryDoRankUpdate is mostly for testing: it shouldn't have any measureable impact on the astrometry fitter, but it's helpful to demonstrate that FitterBase.minimize() is behaving sanely when we doRankUpdate=False (which is the point of the astrometry skip_rank_update test).
parejkoj
force-pushed
the
tickets/DM-13671
branch
from
ff8f9b3
to
8723d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.