Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-13671 add option to skip rank update #80

Merged
merged 5 commits into from
May 20, 2018
Merged

Commits on May 16, 2018

  1. Rename SpMat->SparseMatrixD

    parejkoj committed May 16, 2018
    Configuration menu
    Copy the full SHA
    3a2fa40 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2018

  1. Add option to skip rank update when minimizing.

    Add jointcalConfig option to skip photometry and astrometry rank update.
    Add FitterBase support for skipping rank update.
    Add decam photometry and astrometry tests with and without rank update.
    Decam photometry doRankUpdate test doesn't work, and is part of the set of
    "differs on macOS" tests, so we're skipping it for now.
    
    Lift out Hessian creation into anonymous function.
    
    NOTE: astrometryDoRankUpdate is mostly for testing: it shouldn't have any
    measureable impact on the astrometry fitter, but it's helpful to demonstrate
    that FitterBase.minimize() is behaving sanely when we doRankUpdate=False
    (which is the point of the astrometry skip_rank_update test).
    parejkoj committed May 20, 2018
    Configuration menu
    Copy the full SHA
    a4c0c0a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fe5cc5e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    80e2dd2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8723d00 View commit details
    Browse the repository at this point in the history