New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compute default EUPS_PKGROOT for tarball packages #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athornton
approved these changes
Mar 29, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit.
jhoblitt
force-pushed
the
tickets/DM-9526-pkgroot
branch
13 times, most recently
from
March 31, 2017 23:29
9d56a51
to
6286cfe
Compare
jhoblitt
force-pushed
the
tickets/DM-9526-pkgroot
branch
13 times, most recently
from
April 13, 2017 19:44
6ec18d8
to
2c5d0e3
Compare
jhoblitt
force-pushed
the
tickets/DM-9526-pkgroot
branch
2 times, most recently
from
April 13, 2017 20:06
0279e6b
to
98578c5
Compare
jhoblitt
force-pushed
the
tickets/DM-9526-pkgroot
branch
9 times, most recently
from
April 20, 2017 19:48
62c5f53
to
99b71ea
Compare
The sole function of this product appears to be to setup the EUPS_PKGROOT env var. This is no-longer desired as we need to dynamically generate the EUPS_PKGROOT on platforms for which binary EUPS "tarballs" are being generated. Additionally, as a side effect of its use of sconUtils, it requires that scons/doxygen/etc. be built. This is unnecessary during a boot strap phase as any required deps are properly pulled in during a distrib install. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit.
As this env was generic enough to possibly conflict with other packages, it is being preemptively renamed.
Which may be left over from a previous failed installation attempt.
This is intended to reduce the amount of console output when running under CI.
This is intended to reduce the amount of console output when running under CI.
jhoblitt
force-pushed
the
tickets/DM-9526-pkgroot
branch
from
April 20, 2017 23:03
48b8485
to
f5d796a
Compare
jhoblitt
changed the title
(WIP) compute default EUPS_PKGROOT for tarball packages
compute default EUPS_PKGROOT for tarball packages
May 3, 2017
jhoblitt
changed the title
compute default EUPS_PKGROOT for tarball packages
compute default EUPS_PKGROOT for tarball packages
May 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.