assorted trivial fixes and style cleanups #41
Conversation
There was a problem hiding this comment.
YAY accommodation for those of us who know that 80 columns is enough!
One other thing. == is a bashism, and = is POSIX. The shebang says you're using bash, so that's fine, except then I think the file should be called newinstall.bash but then that would break a lot of stuff, I bet.
|
I think the instructions tell people to run it as |
|
@athornton |
jhoblitt
force-pushed
the
tickets/DM-9526-pkgroot-cleanups
branch
from
567f278
to
2cd1f8f
Compare
|
I've tacked on some fixes to the "up2date" check so it does give an ugly error message when piping the script into the shell. I'll wait for CI to pass again before merging. |
|
@athornton Brings up a good point about 80 cols. That has been irritating me too. I will add a reformatting commit. |
|
The "80cols" changeset gets almost every line <= 80 cols with a tabstop of 2. |
jhoblitt
force-pushed
the
tickets/DM-9526-pkgroot-cleanups
branch
3 times, most recently
from
7d924e1
to
51b5259
Compare
jhoblitt
force-pushed
the
tickets/DM-9526-pkgroot-cleanups
branch
from
932e90a
to
6e02795
Compare
Note that this is intentionally optimizing the script for editability rather than consistent line wrapping length for output.
The presence of these characters seems to break the parser of the
version of bash shipped with OSX:
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin15)
jhoblitt
force-pushed
the
tickets/DM-9526-pkgroot-cleanups
branch
from
58eaa40
to
3de52ef
Compare
|
There is still a weird failure on osx that I don't fully understand but it seems to be caused by travis running the build from a non-login shell. The rvm folks have a work around for it: However, I'm going to go ahead and merge this since I can't reproduce the failure by hand. |
Split out of #37