namespace all functions

[jhoblitt]

No description provided.

[jhoblitt]

Minor fixes/corrections were made that came up while writing examples but no major refactoring, even where it obviously should be done, was made. The intent is to establish a baseline before further changes are made.

[timj]

The changes to newinstall.sh are fine. There is a huge amount of Ruby code here that I'm not going to review in detail. Did you auto generate this? I am worried that some of it seems to be testing things like "does the message contain the right string" which is not really what test frameworks are meant to test. For example the tests will need fixing when #68 merges (which will be before this merges because I'm waiting for Travis).

[jhoblitt]

I'm afraid I keyed it all by hand. In many cases, there are no side effects to observe (that is, rspec-bash is able to observe) from a function to indicate which code path it has gone down other than output. It does end up being a bit more fragile for refactoring than a BDD ideal. However, I wouldn't want to try to write aruba or cucumber tests for the output of newinstall.sh, so breaking it up into small pieces is more tractable. It also means there isn't an acceptance test framework that is brittle for output changes.

[jhoblitt]

Repushed with the missing require statement.

[jhoblitt]

The travis env is, amazingly, missing /usr/bin/true.