Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warning for known problematic env vars #72

Merged
merged 2 commits into from Sep 20, 2017
Merged

add warning for known problematic env vars #72

merged 2 commits into from Sep 20, 2017

Conversation

jhoblitt
Copy link
Member

No description provided.

timj
timj approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. Two fixes needed. I still worry each time I see the rspect code being significantly longer than the code you add to newinstall.

scripts/newinstall.sh Outdated

if [[ ${#problems} -gt 0 ]]; then
n8l::print_error "$(cat <<-EOF
WARNING: the following environment variables are defined that will effect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"affect"

scripts/newinstall.sh Outdated

n8l::print_error "$(cat <<-EOF

It is recommend that they are undefined before running this script.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"recommended"

@jhoblitt jhoblitt force-pushed the tickets/DM-11949-warn-vars branch 3 times, most recently from e9231f9 to 5210a76 Compare September 19, 2017 22:08
@jhoblitt
Copy link
Member Author

I'm not sure why? rspec is no more verbose than unittest would be with a couple of examples per method with 3-4 assertions and some mocking.

@jhoblitt
Copy link
Member Author

Ugh. This needs a rethink as LSST_HOME is defined in the script.

@jhoblitt jhoblitt merged commit 79be6cb into master Sep 20, 2017
@ktlim ktlim deleted the tickets/DM-11949-warn-vars branch August 25, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

@jonathansick jonathansick Awaiting requested review from jonathansick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhoblitt @timj