DM-32408: Initial implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
timj
force-pushed
the
tickets/DM-32408
branch
3 times, most recently
from
193397e
to
7c51e24
Compare
ktlim
approved these changes
Apr 13, 2022
* Determine version using GitPython. * Register setuptools entry point.
timj
commented
Apr 13, 2022
timj
force-pushed
the
tickets/DM-32408
branch
6 times, most recently
from
bffe4f3
to
649d447
Compare
Added as a tar file that is extracted before the tests run.
Now if a commit is associated with a release version, report that version instead of a development version.
ktlim
reviewed
Apr 15, 2022
* Use dev tag for tests and remove requirements.txt The requirements.txt is only meant to be present for applications. * Use pip cache. * Install the package when mypy is used so as to ensure all dependencies are installed.
Normalizing up front prevents setuptools from complaining that the version number needs to be normalized. This should not really happen with weekly tags but can happen for packages that have not yet had a weekly tag or those that have slightly non-standard release tags.
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage ? 75.00%
=======================================
Files ? 3
Lines ? 140
Branches ? 0
=======================================
Hits ? 105
Misses ? 35
Partials ? 0 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.