Added initial astrometry source selector, base class and tests. #38
Conversation
|
|
||
| The additional tests for a good centroid, beyond isUsable, are: | ||
| - not interpolated in the center (this includes saturated sources, | ||
| so we don't test separately for that) |
There was a problem hiding this comment.
This comment is confusing, since it looks like you do test separately for saturated sources below.
There was a problem hiding this comment.
Comment was in the original code I stole this from (measOptimisticB). I added the separate saturated check, since I'm using fake data. I think I'd rather leave it in, to catch corner cases (plus, I don't know anything about how interpolatedCenter and saturated interact beyond that one comment).
parejkoj
force-pushed
the
tickets/DM-5933
branch
from
ed97695
to
eaa7800
Compare
| @@ -0,0 +1,121 @@ | |||
| # See COPYRIGHT file at the top of the source tree. | |||
There was a problem hiding this comment.
Can we do this now? It's nice and short, but I don't see a COPYRIGHT file anywhere in the meas_algorithms repo.
There was a problem hiding this comment.
I'm taking this from jointcal, where I was told to do it that way (THE FUTURE!). I'll check with SQuaRE.
There was a problem hiding this comment.
Word from SQuaRE is that we can't quite do the switch yet on existing projects. @jonathansick is planning a full switch for the whole codebase VerySoonNow™. I've added the copyright at the top.
This is the first non-PSF source selector, with a new base class for other generic catalog-based source selectors. It was lifted from measOptimisticB for use by jointcal. Although it passes all tests and should work as a replacement for SourceInfo from matchOptimisticB, it appears to be not quite strict enough for jointcal yet, so may require some more work for that.
parejkoj
force-pushed
the
tickets/DM-5933
branch
from
f9fa16f
to
b9bc28a
Compare
This is the first non-PSF source selector, with a new base class for other such things. It was lifted from measOptimisticB for use by jointcal.