Tickets/dm 3265 #15
Merged
Tickets/dm 3265 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, if the WCSs were not approximately equal, the unit test would just print an error message, but not raise an exception
raises a UserWarning if the validation fails
rather than using a separate function wcsNearlyEqualOverBBox, this code now just creates a fake unit test class and calls the assert method assertWcsNearlyEqualOverBBox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made approximateWcs a method, rather than a task.
I also altered it so that you can specify a tolerance in sky coordinates and pixel coordinates for difference between the two WCSs. If they input WCS and approximate WCS differ by more than the specified tolerance, a UserWarning is raised. This necessitated a small change in afw, which I will send you in another PR (with the same name as this PR).