Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets/dm 3265 #15

Merged
merged 8 commits into from
Jul 30, 2015
Merged

Tickets/dm 3265 #15

merged 8 commits into from
Jul 30, 2015

Commits on Jul 29, 2015

  1. moved approximateWcs to its own file

    @danielsf
    danielsf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    6aa9ed7 View commit details
    Browse the repository at this point in the history

  2. unit test actually fails if the fitting of the WCS does not work 

    previously, if the WCSs were not approximately equal, the unit test
would just print an error message, but not raise an exception
    @danielsf
    danielsf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    a3d7548 View commit details
    Browse the repository at this point in the history

  3. whitespace

    @danielsf
    danielsf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    3613044 View commit details
    Browse the repository at this point in the history

  4. approxiateWcs now validates the approximation; 

    raises a UserWarning if the validation fails
    @danielsf
    danielsf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    ae54969 View commit details
    Browse the repository at this point in the history

  5. print messages returned by wcsNearlyEqualOverBBox in a more readable 

    fashion
    @danielsf
    danielsf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    bf8682b View commit details
    Browse the repository at this point in the history

  6. added unit test to make sure that approximateWcs returns UserWarnings 

    when appropriate
    @danielsf
    danielsf committed Jul 29, 2015
    Configuration menu
    Copy the full SHA
    4a52f39 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2015

  1. as per Russell Owen's suggestion in the code review, 

    rather than using a separate function wcsNearlyEqualOverBBox,
this code now just creates a fake unit test class and calls the assert method
assertWcsNearlyEqualOverBBox
    @danielsf
    danielsf committed Jul 30, 2015
    Configuration menu
    Copy the full SHA
    aeb07b2 View commit details
    Browse the repository at this point in the history

  2. clean up whitespace

    @danielsf
    danielsf committed Jul 30, 2015
    Configuration menu
    Copy the full SHA
    0a6f3cc View commit details
    Browse the repository at this point in the history