DM-11356: Confusion of refObjLoader.pixelMargin and matcher.maxOffsetPix #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change to metadata and configs, are clear and accepted. |
LoadReferenceObjectsTask is the consumer of the 'match metadata', and therefore, to maintain encapsulation, it should produce it.
This grow is already performed by the reference catalog loader, but it is controlled by the refObjLoader.pixelMargin parameter. That parameter now matches maxOffsetPix. Added a note to maxOffsetPix that the pixelMargin should be coordinated.
PaulPrice
force-pushed
the
tickets/DM-11356
branch
from
705d232
to
13f80ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.