Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-11356: Confusion of refObjLoader.pixelMargin and matcher.maxOffsetPix #74

Merged
merged 2 commits into from
Sep 5, 2017
Merged

DM-11356: Confusion of refObjLoader.pixelMargin and matcher.maxOffsetPix #74

merged 2 commits into from
Sep 5, 2017

Commits on Sep 5, 2017

  1. move createMatchMetadata functionality to LoadReferenceObjectsTask 

    LoadReferenceObjectsTask is the consumer of the 'match metadata',
and therefore, to maintain encapsulation, it should produce it.
    @PaulPrice
    PaulPrice committed Sep 5, 2017
    Configuration menu
    Copy the full SHA
    05501bc View commit details
    Browse the repository at this point in the history

  2. AstrometryTask: remove grow by maxOffsetPix 

    This grow is already performed by the reference catalog loader, but it
is controlled by the refObjLoader.pixelMargin parameter. That parameter
now matches maxOffsetPix. Added a note to maxOffsetPix that the pixelMargin
should be coordinated.
    @PaulPrice
    PaulPrice committed Sep 5, 2017
    Configuration menu
    Copy the full SHA
    13f80ab View commit details
    Browse the repository at this point in the history