Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-37532: use pybind wrappers, create only one shared lib #233

Merged
merged 1 commit into from Feb 11, 2023
Merged

DM-37532: use pybind wrappers, create only one shared lib #233

merged 1 commit into from Feb 11, 2023

Conversation

mwittgen
Copy link
Contributor

No description provided.

@mwittgen mwittgen mentioned this pull request Jan 30, 2023
Merged
@mwittgen mwittgen requested a review from erykoff February 3, 2023 20:01
erykoff
erykoff approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I guess we decided we don't need stub files and should just fix our own code like meas_extensions_gaap?

@mwittgen mwittgen merged commit e3b0dce into main Feb 11, 2023
@mwittgen mwittgen deleted the tickets/DM-37532 branch February 11, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mwittgen @erykoff