DM-37532: Fix meas_base imports #28
Conversation
| @@ -35,7 +35,7 @@ | |||
| import lsst.afw.table as afwTable | |||
| import lsst.geom | |||
| import lsst.meas.base as measBase | |||
| from lsst.meas.base.fluxUtilities import FluxResultKey | |||
| from lsst.meas.base import FluxResultKey | |||
There was a problem hiding this comment.
If we are going to import FluxResultKey from measBase, we might as well not do it and use it FluxResultKey with the namespace specified wherever it is used.
There was a problem hiding this comment.
Yes, the code is already importing measBase so may as well use measBase.FluxResultKey in here and remove the second import completely.
There was a problem hiding this comment.
Implemented to use measBase and tested locally against meas_base changes in
lsst/meas_base#233
as well with the latest daily release.
|
One minor nitpicky comment is that the commit messages should begin with capitalized letter, according to the Tim Pope's best committing practices linked from our dev guide: https://developer.lsst.io/work/flow.html#git-commit-message-best-practices |
mwittgen
changed the title
mwittgen
force-pushed
the
tickets/DM-37532
branch
from
4030370
to
5544741
Compare
|
Capitalized git commit message. Will fix messages in the related pybind packages as well. |
No description provided.