Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42811: Log unexpected measurement exceptions as WARNING #266

Merged
merged 1 commit into from Apr 18, 2024
Merged

DM-42811: Log unexpected measurement exceptions as WARNING #266

merged 1 commit into from Apr 18, 2024

Conversation

parejkoj
Copy link
Contributor

No description provided.

TallJimbo
TallJimbo approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the context we discussed on slack to the commit message, i.e. "these were turned from WARNING to DEBUG on ticket X, which was supposed to be about adding new DEBUG logs for other errors but communicated poorly".

@parejkoj
Change non-MeasurementErrors to warnings
2c1d189 
This corrects a miscommunication on DM-9574, which was supposed to be about
adding new DEBUG logs for other errors, but which was applied too broadly.
These exceptions tell us about important failure modes that we should fix, so
we shouldn't be hiding them in the debug logs.
@parejkoj parejkoj merged commit 6c1bc30 into main Apr 18, 2024
2 checks passed
@parejkoj parejkoj deleted the tickets/DM-42811 branch April 18, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@parejkoj @TallJimbo