DM-34254: Validate piff psf kernel size vs. input psf candidates #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be caught by MeasurePsfTask, or by piff itself, but if not it can result in catastrophically bad fits.
Remove pointless `exposure` arg. Use actual PiffPsfDeterminer classes instead of registry.
ebellm
reviewed
May 4, 2022
| @@ -315,5 +316,28 @@ def determinePsf( | |||
|
|
|||
| return psf, None | |||
|
|
|||
| def _validatePsfCandidates(self, psfCandidateList, kernelSize): | |||
There was a problem hiding this comment.
Do the psfCandidates in psfCandidateList have a well-defined (constant) size? The python for loop in this function is adding an unnecessary performance hit if so.
There was a problem hiding this comment.
Good question: we don't enforce the psfCandidate size when constructing that list (and it's just a list, not a coherent data structure). But the primary usage gets them from MakePsfCandidatesTask, which has a single config.kernelSize. So, I think you're right that we can just assume they're all the same and only test the first one. I do hope that piff upstream implements an internal check as well, though.
We can pretty safely assume all the candidates have the same dimensions.
ebellm
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.