Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-34254: Validate piff psf kernel size vs. input psf candidates #11

Merged
merged 5 commits into from
May 6, 2022
Merged

DM-34254: Validate piff psf kernel size vs. input psf candidates #11

merged 5 commits into from
May 6, 2022

Commits on Apr 28, 2022

  1. Fix commented-out readme line

    @parejkoj
    parejkoj committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    1b77478 View commit details
    Browse the repository at this point in the history

  2. Validate psf candidates 

    This should be caught by MeasurePsfTask, or by piff itself, but if not
it can result in catastrophically bad fits.
    @parejkoj
    parejkoj committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    e57b669 View commit details
    Browse the repository at this point in the history

  3. Refactor piff tests to test different kernelSizes 

    Remove pointless `exposure` arg.
Use actual PiffPsfDeterminer classes instead of registry.
    @parejkoj
    parejkoj committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    629a592 View commit details
    Browse the repository at this point in the history

  4. Use kernelSize as determined at runtime

    @parejkoj
    parejkoj committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    05f8ccf View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Only check the first candidate 

    We can pretty safely assume all the candidates have the same dimensions.
    @parejkoj
    parejkoj committed May 5, 2022
    Configuration menu
    Copy the full SHA
    871a598 View commit details
    Browse the repository at this point in the history