DM-5532 #4
Merged
DM-5532 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests/testPsfexPsf.py to work with the new star selector class hierarchy and API
Remove unused commits Change "from math import *" to "import math" Stop setting a variable that was unused
Standardize argument names for selectStars by renaming catalog to sourceCat
Make PsfexStarSelector a subclass of StarSelectorTask and append Task to the name. Update the API accordingly: selectStars now returns a catalog of stars instead of a list of PSF candidates.
Add full task documentation to PsfExStarSelectorTask
Simplify a unit test that runs a star selector to use the run method when PSF candidates are wanted.
| "base_PixelFlags_flag_saturated.center", | ||
| "base_PixelFlags_flag_cr.center", | ||
| "base_PixelFlags_flag_bad", | ||
| "base_PixelFlags_flag_suspect.center", |
There was a problem hiding this comment.
I'm pretty sure these .center strings aren't correct anymore.
Update outdated schema flag names.
Remove trailing whitespace, one trailing semicolon and split one pair of expressions into two lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.