DM-20566: Replace afwGeom with geom #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
approved these changes
Jul 16, 2019
| @@ -28,6 +28,7 @@ | |||
| import lsst.afw.image as afwImage | |||
| import lsst.afw.detection as afwDetection | |||
| import lsst.afw.geom as afwGeom | |||
| import lsst.geom as geom | |||
There was a problem hiding this comment.
You couldn't also remove the afwGeom above?
There was a problem hiding this comment.
No, because makeSkyWcs is used here.
timj
force-pushed
the
tickets/DM-20566-meas_extensions_psfex
branch
from
17eac5f
to
8d327fd
Compare
flake8 tests not enabled because there are some fundamental issues in the code with variables being used that are not defined. See DM-4905, DM-5684
There are some places in here where variables are used that have not been defined. We don't seem to be using this code but it's easier to raise an exception rather than try to delete particular if-branches.
timj
force-pushed
the
tickets/DM-20566-meas_extensions_psfex
branch
from
8d327fd
to
986a842
Compare
|
I've had a look at the 4 problematic areas. Fixes are not obvious so I've put in exceptions (they would throw any how) to be a bit more explicit about it. |
parejkoj
reviewed
Jul 16, 2019
|
I'm not sure of anything, but since they are branches that people might encounter, even if we removed the code in the branch we should still retain the exception raising rather than ignoring the configuration option. I'm therefore inclined to leave it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some flake8 fixes as well but the package has some fundamental problems with variables being used that are not defined.